anomaly localization integration step 3 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lai <57818076+wnbts@users.noreply.github.com>
ylwu-amzn
reviewed
Jan 7, 2022
| /** | ||
| * Output of localized results. | ||
| */ | ||
| @Data | ||
| public class Output implements ToXContent { | ||
| @NoArgsConstructor | ||
| public class Output implements org.opensearch.ml.common.parameter.Output { |
There was a problem hiding this comment.
How about rename the class name to avoid full class path org.opensearch.ml.common.parameter.Output as they have same class name?
ylwu-amzn
reviewed
Jan 7, 2022
| case Output.Entity.FIELD_NEW_VALUE: | ||
| parser.nextToken(); | ||
| entity.setNewValue(parser.doubleValue()); | ||
| break; |
There was a problem hiding this comment.
Skip children for default case? Same question for other places
default:
parser.skipChildren();
break;
Signed-off-by: lai <57818076+wnbts@users.noreply.github.com>
ylwu-amzn
previously approved these changes
Jan 10, 2022
jackiehanyang
previously approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lai 57818076+wnbts@users.noreply.github.com
Description
the changes are for step 3 in anomaly localization integration
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.