-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration step 1 and 2 for anomaly localization #113
Conversation
Signed-off-by: lai <57818076+wnbts@users.noreply.github.com>
/** | ||
* Information about aggregate, time, etc to localize. | ||
*/ | ||
@Data | ||
public class Input { | ||
@AllArgsConstructor | ||
public class Input implements org.opensearch.ml.common.parameter.Input { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we rename this class name to avoid full class path org.opensearch.ml.common.parameter.Input
as they have same class name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, renamed.
ensureExpectedToken(XContentParser.Token.START_OBJECT, parser.nextToken(), parser); | ||
filterQuery = Optional.of(parseInnerQueryBuilder(parser)); | ||
ensureExpectedToken(XContentParser.Token.END_OBJECT, parser.currentToken(), parser); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip children for default case?
default:
parser.skipChildren();
break;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure added
Signed-off-by: lai <57818076+wnbts@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change!
Signed-off-by: lai 57818076+wnbts@users.noreply.github.com
Description
the changes are step 1 and 2 for anomaly localization integration.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.