Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sha256 on gradle 7.6.1 #900

Merged
merged 1 commit into from
May 10, 2023

Conversation

jmazanec15
Copy link
Member

Description

Fixes checksum for gradle 7.6.1

Related: https://github.com/opensearch-project/k-NN/actions/runs/4931642285/jobs/8813885647

Checksums can be found here.

Command to generate:

./gradlew wrapper --gradle-version 7.6.1 --gradle-distribution-sha256-sum 518a863631feb7452b8f1b3dc2aaee5f388355cc3421bbd0275fbeadd77e84b2 --distribution-type all

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15
Copy link
Member Author

Secure tests failures are unrelated.

@jmazanec15 jmazanec15 merged commit 8636cde into opensearch-project:main May 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #900 (1f276e7) into main (fd4b9f1) will decrease coverage by 0.32%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##               main     #900      +/-   ##
============================================
- Coverage     85.35%   85.03%   -0.32%     
+ Complexity     1089     1084       -5     
============================================
  Files           152      152              
  Lines          4404     4404              
  Branches        389      389              
============================================
- Hits           3759     3745      -14     
- Misses          470      482      +12     
- Partials        175      177       +2     
Impacted Files Coverage Δ
...in/transport/TrainingJobRouterTransportAction.java 80.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-900-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8636cde67cdddb694f48231cacd82d7dfeb93c88
# Push it to GitHub
git push --set-upstream origin backport/backport-900-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-900-to-2.x.

jmazanec15 added a commit to jmazanec15/k-NN-1 that referenced this pull request May 10, 2023
Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 mentioned this pull request May 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants