Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors on model deletion failures #834

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Throw errors on model deletion failures #834

merged 8 commits into from
Apr 13, 2023

Commits on Apr 10, 2023

  1. Throw errors on model deletion failures 

    Throws errors on model deletion. Previously we were indicating failure,
but returning 200 response codes. This changes that to throw exceptions
with the correct response code.

Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    0125dcf View commit details
    Browse the repository at this point in the history

  2. Update changelog 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    9c36e31 View commit details
    Browse the repository at this point in the history

  3. Fix bwc model test 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    71394f0 View commit details
    Browse the repository at this point in the history

  4. Update exception comments 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    165f400 View commit details
    Browse the repository at this point in the history

  5. Fix delete training model cleanup in bwc 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    14151de View commit details
    Browse the repository at this point in the history

  6. Fix rebase related errors 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    a0f3c0e View commit details
    Browse the repository at this point in the history

  7. Fix corner case string format bug 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    02f7129 View commit details
    Browse the repository at this point in the history

  8. Move error logger to listener 

    Signed-off-by: John Mazanec <jmazane@amazon.com>
    @jmazanec15
    jmazanec15 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    a730725 View commit details
    Browse the repository at this point in the history