Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace terminology 'master' with 'cluster manager' #521

Conversation

naveentatikonda
Copy link
Member

Signed-off-by: Naveen Tatikonda navtat@amazon.com

Description

Nomenclature Changes- Replace "master" with "cluster manager"

The below two packages are still not supported by opensearch core and is expected to be ready by 3.0 :

  • org.opensearch.action.support.master.AcknowledgedRequest -> org.opensearch.action.support.clusterManager.AcknowledgedRequest

  • org.opensearch.action.support.master.AcknowledgedResponse -> org.opensearch.action.support.clusterManager.AcknowledgedResponse

Issues Resolved

#307

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@VijayanB
Copy link
Member

i see bcakport label but comment says ready by 3.0. Is that accurate?

@tlfeng
Copy link

tlfeng commented Aug 29, 2022

@VijayanB The class path for the 2 classes AcknowledgedRequest and AcknowledgedResponse will be renamed from org.opensearch.action.support.master to org.opensearch.action.support.clustermanager in version 3.0 , but they are not included in this PR, so it's reasonable to backport this PR to 2.x branch.

@VijayanB
Copy link
Member

@VijayanB The class path for the 2 classes AcknowledgedRequest and AcknowledgedResponse will be renamed from org.opensearch.action.support.master to org.opensearch.action.support.clustermanager in version 3.0 , but they are not included in this PR, so it's reasonable to backport this PR to 2.x branch.

@tlfeng Got it. Thanks for clarification.

@navneet1v navneet1v merged commit 268bc67 into opensearch-project:main Aug 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit 268bc67)
naveentatikonda pushed a commit that referenced this pull request Aug 30, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
martin-gaievski pushed a commit that referenced this pull request Sep 28, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@heemin32 heemin32 added v2.3.0 'Issues and PRs related to version v2.3.0' and removed 2.3.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement v2.3.0 'Issues and PRs related to version v2.3.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants