Nomenclature changes from master to cluster manager #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we change this one as well, it's our method independent from core OS - https://github.com/opensearch-project/k-NN/blob/main/src/test/java/org/opensearch/knn/plugin/transport/UpdateModelMetadataTransportActionTests.java#L55? |
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
nomenclature_changes
branch
from
c62b9a3 to
e816521
Compare
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
=========================================
Coverage 84.01% 84.01%
Complexity 911 911
=========================================
Files 130 130
Lines 3879 3879
Branches 359 359
=========================================
Hits 3259 3259
Misses 458 458
Partials 162 162
Continue to review full report at Codecov.
|
Shivamdhar
approved these changes
Apr 18, 2022
martin-gaievski
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda navtat@amazon.com
Description
Change
masternomenclature tocluster manager. Still there are few changes(package names, method names) which needs to be done. Will make those changes after those changes are implemented in opensearch core.Issues Resolved
#307
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.