Update package name to fix compilation issue #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
Vikasht34
previously approved these changes
Feb 10, 2025
VijayanB
force-pushed
the
fix-compile
branch
2 times, most recently
from
d74426e to
905c9cb
Compare
Vikasht34
previously approved these changes
Feb 10, 2025
naveentatikonda
previously approved these changes
Feb 10, 2025
|
@VijayanB did core also backported these changes to 2.x? |
good question |
I don't think so. This failure is only available in main branch. Given next release is 3.0, not sure what is the procedure here. Are we going to backport to 2.x starting release of 2.19? |
|
mac os failed due to flaky test: #1522 |
VijayanB
dismissed stale reviews from naveentatikonda and Vikasht34
via
a4bea6f
Core renamed this package in opensearch-project/OpenSearch#17272 This commit renames package accordingly Signed-off-by: Balasubramanian <balasvij@amazon.com>
…ith different gcc versions (opensearch-project#2506) (opensearch-project#2508) * Update build gradle to separate nmslib / faiss generation Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update scripts/build.sh to separate enable gcc switch Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Updating restart and rolling upgrade bwc test bundle.gradle Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Enforce gcc10 for nmslib to compile and avx512_spr have no-op Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 107c4f1) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
VijayanB
force-pushed
the
fix-compile
branch
from
a4bea6f to
d723c69
Compare
Vikasht34
approved these changes
Feb 10, 2025
naveentatikonda
approved these changes
Feb 10, 2025
Vikasht34
pushed a commit
to Vikasht34/k-NN
that referenced
this pull request
Feb 12, 2025
* Update package name to fix compilation issue Core renamed this package in opensearch-project/OpenSearch#17272 This commit renames package accordingly Signed-off-by: Balasubramanian <balasvij@amazon.com> * Update build.gradle and build.sh to separate x64 linux nmslib build with different gcc versions (opensearch-project#2506) (opensearch-project#2508) * Update build gradle to separate nmslib / faiss generation Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update scripts/build.sh to separate enable gcc switch Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Updating restart and rolling upgrade bwc test bundle.gradle Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Enforce gcc10 for nmslib to compile and avx512_spr have no-op Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 107c4f1) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Balasubramanian <balasvij@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
navneet1v
pushed a commit
that referenced
this pull request
Feb 17, 2025
…vice (#2532) * fix broken build flag, move build to one directory (#2442) * move build to one directory, fix broken flag Signed-off-by: Samuel Herman <sherman8915@gmail.com> * fix make path Signed-off-by: Samuel Herman <sherman8915@gmail.com> * changelog update Signed-off-by: Samuel Herman <sherman8915@gmail.com> * add fix for classpath change and for cmake discovery on macos Signed-off-by: Samuel Herman <sherman8915@gmail.com> * fix make discovery for gradle Signed-off-by: Samuel Herman <sherman8915@gmail.com> * fix cmake path for macOS Signed-off-by: Samuel Herman <sherman8915@gmail.com> --------- Signed-off-by: Samuel Herman <sherman8915@gmail.com> * Update package name to fix compilation issue (#2513) * Update package name to fix compilation issue Core renamed this package in opensearch-project/OpenSearch#17272 This commit renames package accordingly Signed-off-by: Balasubramanian <balasvij@amazon.com> * Update build.gradle and build.sh to separate x64 linux nmslib build with different gcc versions (#2506) (#2508) * Update build gradle to separate nmslib / faiss generation Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update scripts/build.sh to separate enable gcc switch Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove test comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Updating restart and rolling upgrade bwc test bundle.gradle Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Enforce gcc10 for nmslib to compile and avx512_spr have no-op Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 107c4f1) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Balasubramanian <balasvij@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> * Adds debug logs for KNNQuery and KNNWeight (#2466) (#2470) * Adds debug logs for KNNQuery and KNNWeight Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds check to see if log is enabled to start and stop StopWatch Signed-off-by: Tejas Shah <shatejas@amazon.com> * Addressing comments on the PR Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds shard and segment info in the logs Signed-off-by: Tejas Shah <shatejas@amazon.com> * Removes unnecessary segment name param from exact search Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes the build Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com> (cherry picked from commit f322e27) Co-authored-by: Tejas Shah <shatejas@amazon.com> * Clean JNI artifacts with ./gradlew clean (#2516) * clean JNI artifacts with ./gradlew clean Signed-off-by: Samuel Herman <sherman8915@gmail.com> * nest release under build directory Signed-off-by: Samuel Herman <sherman8915@gmail.com> * adjust all references to the old release path Signed-off-by: Samuel Herman <sherman8915@gmail.com> * remove irrelevant paths from gitignore, add jni/build Signed-off-by: Samuel Herman <sherman8915@gmail.com> * fix logging on linux Signed-off-by: Samuel Herman <sherman8915@gmail.com> --------- Signed-off-by: Samuel Herman <sherman8915@gmail.com> * Backport to main (#2520) * Remove skip building graph check for quantization use case (#2430) For quantization indices, we don't have to apply building graph check since it is already faster, this is now only applied for fp32/16 indices and where threshold is configured. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Update default to 0 to always build graph as default behavior (#2452) Signed-off-by: Balasubramanian <balasvij@amazon.com> * Update changelog Signed-off-by: Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Balasubramanian <balasvij@amazon.com> * [Backport main] Add release notes for 2.19.0 (#2503) * Add release notes for 2.19.0 Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Fix links for release notes Co-authored-by: John Mazanec <jmazane@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> --------- Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com> * Fix main knnlib dir in build script based on #2442 (#2526) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Minor performance improvments in KNNQueryBuilder (#2528) Signed-off-by: Tejas Shah <shatejas@amazon.com> * Initial implementation of control flow Signed-off-by: Rohan Chitale <r.chitale7@gmail.com> --------- Signed-off-by: Samuel Herman <sherman8915@gmail.com> Signed-off-by: Balasubramanian <balasvij@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Rohan Chitale <r.chitale7@gmail.com> Co-authored-by: sam-herman <97131656+sam-herman@users.noreply.github.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com> Co-authored-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core renamed this package in [JPMS Support] Refactoring of
org.opensearch.clientfrom:servermodule OpenSearch#17272 .This commit renames package accordingly
Backport 107c4f1 from Update build.gradle and build.sh to separate x64 linux nmslib build with different gcc versions #2506
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.