Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check for full field name validation #2477

Merged

Conversation

kotwanikunal
Copy link
Member

Description

  • Adds a version check for field name validation
  • This is to prevent issues during version upgrades for users moving from versions <2.17.0 to a higher version - essentially preventing upgrade failures and rendering the check for indexes created on or after 2.17.0

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@shatejas shatejas merged commit 811ae2e into opensearch-project:2.x Jan 31, 2025
117 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 811ae2e)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 811ae2e)
@kotwanikunal kotwanikunal deleted the versioncheck-fieldname branch January 31, 2025 21:03
ryanbogan pushed a commit that referenced this pull request Jan 31, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 811ae2e)

Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 811ae2e)
navneet1v pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 811ae2e)

Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
Vikasht34 pushed a commit to Vikasht34/k-NN that referenced this pull request Feb 12, 2025
…2477) (opensearch-project#2502)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 811ae2e)

Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants