Allow validation for non knn index only after 2.17.0 #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
Before 2.17.0, non knn index are allowed to create knn_vector fields with model id and method params, however this is not allowed from 2.17.0. Hence, to maintain backward compatibility we will not add validation for any indices created before 2.17.0. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-validation-217
branch
from
ca98e93 to
5ede283
Compare
VijayanB
force-pushed
the
add-validation-217
branch
16 times, most recently
from
677fb8d to
c8406c8
Compare
VijayanB
force-pushed
the
add-validation-217
branch
3 times, most recently
from
90babb5 to
2006843
Compare
This is applicable for index created before 2.17 Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-validation-217
branch
from
2006843 to
f70c988
Compare
naveentatikonda
approved these changes
Dec 16, 2024
jmazanec15
approved these changes
Dec 17, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2315-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d57fdea60bb4f52e39db000d965673ac87026cc0
# Push it to GitHub
git push --set-upstream origin backport/backport-2315-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
VijayanB
added a commit
to VijayanB/k-NN-2
that referenced
this pull request
Dec 17, 2024
…ect#2315) * Allow validation for non knn index only after 2.17.0 Before 2.17.0, non knn index are allowed to create knn_vector fields with model id and method params, however this is not allowed from 2.17.0. Hence, to maintain backward compatibility we will not add validation for any indices created before 2.17.0. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Add bwc test for model id This is applicable for index created before 2.17 Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
5 tasks
VijayanB
added a commit
that referenced
this pull request
Dec 17, 2024
* Allow validation for non knn index only after 2.17.0 Before 2.17.0, non knn index are allowed to create knn_vector fields with model id and method params, however this is not allowed from 2.17.0. Hence, to maintain backward compatibility we will not add validation for any indices created before 2.17.0. * Add bwc test for model id This is applicable for index created before 2.17 --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
owenhalpert
pushed a commit
to owenhalpert/k-NN
that referenced
this pull request
Dec 19, 2024
…ect#2315) * Allow validation for non knn index only after 2.17.0 Before 2.17.0, non knn index are allowed to create knn_vector fields with model id and method params, however this is not allowed from 2.17.0. Hence, to maintain backward compatibility we will not add validation for any indices created before 2.17.0. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Add bwc test for model id This is applicable for index created before 2.17 Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before 2.17.0, non knn index are allowed to create knn_vector fields with model id and method params, however this is not allowed from 2.17.0. Hence, to maintain backward compatibility we will not add validation for any indices created before 2.17.0.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.