Add BWC tests for Lucene Engine #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddharajusahil
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
added 5 commits
December 6, 2024 16:45
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
buddharajusahil
force-pushed
the
lucene_bwc_tests
branch
from
ba0fb03 to
cf5ea14
Compare
|
@buddharajusahil please fix the failing CIs |
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/IndexingIT.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/IndexingIT.java
Outdated
Show resolved
Hide resolved
naveentatikonda
changed the title
added 3 commits
December 12, 2024 10:19
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com>
naveentatikonda
approved these changes
Dec 16, 2024
jmazanec15
approved these changes
Dec 16, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2313-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f50a8f5383935435784711c124715efcff871b48
# Push it to GitHub
git push --set-upstream origin backport/backport-2313-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
buddharajusahil
added a commit
to buddharajusahil/k-NN
that referenced
this pull request
Dec 17, 2024
Added backward compatibility tests for Lucene engine Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> Co-authored-by: Sahil Buddharaju <sahilbud@amazon.com> (cherry picked from commit f50a8f5)
owenhalpert
pushed a commit
to owenhalpert/k-NN
that referenced
this pull request
Dec 19, 2024
Added backward compatibility tests for Lucene engine Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> Co-authored-by: Sahil Buddharaju <sahilbud@amazon.com>
naveentatikonda
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Add BWC tests for Lucene Engine (#2313) Added backward compatibility tests for Lucene engine Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> Co-authored-by: Sahil Buddharaju <sahilbud@amazon.com> (cherry picked from commit f50a8f5) * changed entity utils import Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> * rerun workflow Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> * rerun CI's Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> * excluded lucene tests on unsupported versions Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> * Missed one more exclude condition in last commit Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> --------- Signed-off-by: Sahil Buddharaju <sahilbud@amazon.com> Signed-off-by: sahil <61558528+buddharajusahil@users.noreply.github.com> Co-authored-by: Sahil Buddharaju <sahilbud@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds bwc tests for Lucene Engine, as there had not been any previously.
Related Issues
Resolves #1725
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.