-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shatejas as the maintainer #2202
Conversation
MAINTAINERS.md
Outdated
@@ -16,3 +16,4 @@ This document contains a list of maintainers in this repo. See [opensearch-proje | |||
| Vamshi Vijay Nakkirtha | [vamshin](https://github.com/vamshin) | Amazon | | |||
| Vijayan Balasubramanian | [VijayanB](https://github.com/VijayanB) | Amazon | | |||
| Yuncheng Lu | [luyuncheng](https://github.com/luyuncheng) | Bytedance | | |||
| Tejas Shah | [shatejas](https://github.com/shatejas) | Amazon | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I believe we were adding maintainers based on alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really? I will fix it.
Signed-off-by: Navneet Verma <navneev@amazon.com>
@peterzhuamazon can you add @shatejas on the maintainers for k-NN. The PR is approved. |
Adding @gaiksaya to the conversation as she is the oncall of the week. Thanks. |
Done! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2202-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07491755e684803aee96c96756a19bb2d438dc79
# Push it to GitHub
git push --set-upstream origin backport/backport-2202-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Adding shatejas as the maintainer. The approval was taken from the maintainer of k-NN repo over email.
Process followed: https://github.com/opensearch-project/.github/blob/main/ADMINS.md#addremove-maintainers
Related Issues
NA
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.