Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarks folder from k-NN repo #2127

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Sep 19, 2024

Description

Remove benchmarks folder from k-NN repo. The removal is needed because of below reasons:

  1. The workloads have been moved to https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/vectorsearch and no updates will be added on these tools.
  2. The python dependencies in code creates CVEs and needs to be regularly updated. Since we no longer use these tools its better to remove the tools.

Related Issues

#1954, #1831, #1830, #1786, #1698, #1687

Check List

  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added skip-changelog Maintenance Add support for new versions of OpenSearch/Dashboards from upstream labels Sep 19, 2024
Signed-off-by: Navneet Verma <navneev@amazon.com>
@naveentatikonda
Copy link
Member

naveentatikonda commented Sep 19, 2024

As a backup, last month I created this branch out of main branch for the benchmarks
https://github.com/opensearch-project/k-NN/tree/knn-benchmarks

@jmazanec15 jmazanec15 merged commit fe1d3e4 into opensearch-project:main Sep 19, 2024
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 19, 2024
Signed-off-by: Navneet Verma <navneev@amazon.com>
(cherry picked from commit fe1d3e4)
@naveentatikonda
Copy link
Member

As a backup, last month I created this branch out of main branch for the benchmarks https://github.com/opensearch-project/k-NN/tree/knn-benchmarks

Just saw that Navneet created another branch old-benchmarks for backup. I will delete the knn-benchmarks branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Maintenance Add support for new versions of OpenSearch/Dashboards from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants