Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
22 tasks
navneet1v
reviewed
Jul 9, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. | ||
| For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/k-NN/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). | ||
| For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/k-nn/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). |
There was a problem hiding this comment.
in k-nn all n's are caps. Even though the link works. but its k-NN and not k-nn.
…cklist. Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
update-pull-request-template
branch
from
6a522b4
to
34ec945
Compare
ryanbogan
approved these changes
Jul 12, 2024
|
Can we get this merged @ryanbogan? |
navneet1v
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.