Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak on test code #1776

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix memory leak on test code #1776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions jni/tests/faiss_wrapper_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,13 +630,13 @@ TEST(FaissCreateHnswSQfp16IndexTest, BasicAssertions) {
// Define the data
faiss::idx_t numIds = 200;
std::vector<faiss::idx_t> ids;
auto *vectors = new std::vector<float>();
std::vector<float> vectors;
int dim = 2;
vectors->reserve(dim * numIds);
vectors.reserve(dim * numIds);
for (int64_t i = 0; i < numIds; ++i) {
ids.push_back(i);
for (int j = 0; j < dim; ++j) {
vectors->push_back(test_util::RandomFloat(-500.0, 500.0));
vectors.push_back(test_util::RandomFloat(-500.0, 500.0));
}
}

Expand All @@ -655,14 +655,14 @@ TEST(FaissCreateHnswSQfp16IndexTest, BasicAssertions) {
EXPECT_CALL(mockJNIUtil,
GetJavaObjectArrayLength(
jniEnv, reinterpret_cast<jobjectArray>(&vectors)))
.WillRepeatedly(Return(vectors->size()));
.WillRepeatedly(Return(vectors.size()));

// Create the index
std::unique_ptr<FaissMethods> faissMethods(new FaissMethods());
knn_jni::faiss_wrapper::IndexService IndexService(std::move(faissMethods));
knn_jni::faiss_wrapper::CreateIndex(
&mockJNIUtil, jniEnv, reinterpret_cast<jintArray>(&ids),
(jlong)vectors, dim, (jstring)&indexPath,
(jlong)&vectors, dim, (jstring)&indexPath,
(jobject)&parametersMap, &IndexService);

// Make sure index can be loaded
Expand Down
Loading