Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcc restrictions to version 12.0.0 #1634

Conversation

peterzhuamazon
Copy link
Member

Description

Update gcc restrictions to version 12.0.0

Issues Resolved

opensearch-project/opensearch-build#4379 (comment)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added Enhancements Increases software capabilities beyond original client specifications release v2.14.0 labels Apr 19, 2024
@peterzhuamazon peterzhuamazon self-assigned this Apr 19, 2024
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Apr 19, 2024

Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterzhuamazon peterzhuamazon marked this pull request as ready for review April 20, 2024 01:37
@peterzhuamazon peterzhuamazon merged commit 11342be into opensearch-project:main Apr 20, 2024
60 of 73 checks passed
@peterzhuamazon peterzhuamazon deleted the update-gcc12-restrictions branch April 20, 2024 02:24
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 11342be)
peterzhuamazon added a commit to peterzhuamazon/k-NN that referenced this pull request Apr 30, 2024
…#1634)"

This reverts commit 11342be.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
navneet1v pushed a commit that referenced this pull request Apr 30, 2024
* Revert "Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib (#1664)"

This reverts commit da4cd1c.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Revert "Update gcc restrictions to version 12.0.0 (#1634)"

This reverts commit 11342be.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
* Revert "Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib (#1664)"

This reverts commit da4cd1c.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Revert "Update gcc restrictions to version 12.0.0 (#1634)"

This reverts commit 11342be.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit f432b0e)
peterzhuamazon added a commit that referenced this pull request Apr 30, 2024
* Revert "Ensure gcc is newer >= 11.2.1 < 12.0.0 when building knn lib (#1664)"

This reverts commit da4cd1c.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Revert "Update gcc restrictions to version 12.0.0 (#1634)"

This reverts commit 11342be.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit f432b0e)

Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Enhancements Increases software capabilities beyond original client specifications release skip-changelog v2.14.0
Projects
Development

Successfully merging this pull request may close these issues.

3 participants