Fix KNNScorer to apply boost #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugmakerrrrrr
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
|
Could you update CHANGELOG? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
============================================
- Coverage 85.01% 84.99% -0.02%
+ Complexity 1275 1274 -1
============================================
Files 167 167
Lines 5179 5179
Branches 483 483
============================================
- Hits 4403 4402 -1
Misses 572 572
- Partials 204 205 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
bugmakerrrrrr
force-pushed
the
boost_missing
branch
from
2501134 to
3104ca7
Compare
heemin32
approved these changes
Jan 23, 2024
heemin32
approved these changes
Jan 23, 2024
martin-gaievski
approved these changes
Jan 23, 2024
|
Thanks for the contribution! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
* apply boost Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit fcbfef1)
heemin32
pushed a commit
that referenced
this pull request
Jan 23, 2024
* apply boost Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit fcbfef1) Co-authored-by: panguixin <panguixin@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using boost along with the
KNNQuery, the boost is not applied.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.