Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from rockylinux8 to centos7 docker image for legacy support before deprecation #1204

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Switch from rockylinux8 to centos7 docker image for legacy support before deprecation #1204

merged 1 commit into from
Oct 6, 2023

Conversation

peterzhuamazon
Copy link
Member

Description

Switch from rockylinux8 to centos7 docker image for legacy support before deprecation

Issues Resolved

#1042

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Switch from rockylinux8 to centos7 docker image for legacy support be…
e8a67f7 
…fore deprecation

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. enhancement ci labels Oct 6, 2023
@peterzhuamazon peterzhuamazon self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #1204 (e8a67f7) into main (276dba7) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1204      +/-   ##
============================================
+ Coverage     85.03%   85.09%   +0.06%     
  Complexity     1209     1209              
============================================
  Files           160      160              
  Lines          4938     4938              
  Branches        448      448              
============================================
+ Hits           4199     4202       +3     
+ Misses          540      537       -3     
  Partials        199      199

see 1 file with indirect coverage changes

@navneet1v navneet1v merged commit 4cbc2f1 into opensearch-project:main Oct 6, 2023
46 of 64 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
@peterzhuamazon @github-actions
Switch from rockylinux8 to centos7 docker image for legacy support be…
d76d7af 
…fore deprecation (#1204)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 4cbc2f1)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 6, 2023
Merged
@peterzhuamazon peterzhuamazon deleted the tweak-docker-images-in-build-workflows branch October 6, 2023 23:59
peterzhuamazon added a commit that referenced this pull request Oct 7, 2023
@opensearch-trigger-bot @peterzhuamazon
Switch from rockylinux8 to centos7 docker image for legacy support be…
def209e 
…fore deprecation (#1204) (#1209)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 4cbc2f1)

Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navneet1v navneet1v navneet1v approved these changes

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

Assignees

@peterzhuamazon peterzhuamazon

Labels
backport 2.x enhancement Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. skip-changelog
Projects
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterzhuamazon @navneet1v @jmazanec15