Fix the flaky in allocation IT during multinode test #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
commented
Oct 4, 2023
| @@ -100,9 +97,6 @@ class AllocationActionIT : IndexStateManagementRestTestCase() { | |||
| assertEquals(actionConfig.require["_name"], settings["index.routing.allocation.require._name"]) | |||
| } | |||
|
|
|||
| // Third execution: Waits for allocation to complete, which will happen in this execution since index is small | |||
There was a problem hiding this comment.
No need to trigger the third execution, since the second execution already apply the allocation setting, and we just need to wait for the setting takes effect
The third execution trigger seems collide with the deletion of ISM system index in multi-node test, which could like to a corrupt node lock. Check the analysis here #90 (comment)
Codecov Report
@@ Coverage Diff @@
## main #983 +/- ##
============================================
- Coverage 74.69% 74.56% -0.13%
+ Complexity 2753 2751 -2
============================================
Files 361 361
Lines 16077 16077
Branches 2314 2314
============================================
- Hits 12008 11988 -20
- Misses 2788 2811 +23
+ Partials 1281 1278 -3 |
bowenlan-amzn
requested review from
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt and
jowg-amazon
as code owners
AWSHurneyt
approved these changes
Oct 5, 2023
jowg-amazon
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 502097e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 502097e) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Joshua152
pushed a commit
to Joshua152/index-management
that referenced
this pull request
Oct 10, 2023
…ect#983) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.