Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes checked in js zip [BACKPORT] #411

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

downsrob
Copy link
Contributor

Issue #, if available:
#402

Description of changes:
Backport of #403

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #411 (7d70dea) into 1.3 (dae81c5) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                1.3     #411      +/-   ##
============================================
- Coverage     75.66%   75.48%   -0.19%     
  Complexity     2009     2009              
============================================
  Files           253      253              
  Lines         11489    11490       +1     
  Branches       1819     1819              
============================================
- Hits           8693     8673      -20     
- Misses         1765     1789      +24     
+ Partials       1031     1028       -3     
Impacted Files Coverage Δ
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 66.56% <100.00%> (+0.10%) ⬆️
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-27.54%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 59.25% <0.00%> (-5.56%) ⬇️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 76.63% <0.00%> (-1.41%) ⬇️
...earch/indexmanagement/transform/TransformRunner.kt 85.71% <0.00%> (-0.72%) ⬇️
...xmanagement/rollup/actionfilter/FieldCapsFilter.kt 74.11% <0.00%> (+1.17%) ⬆️
...nt/indexstatemanagement/model/destination/Chime.kt 54.54% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae81c5...7d70dea. Read the comment docs.

downsrob and others added 2 commits July 18, 2022 18:07
* Removes job scheduler static dependency

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Removes print statement to fix dependency order

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Adds missed code

Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
@downsrob downsrob marked this pull request as ready for review July 18, 2022 18:49
@downsrob downsrob requested a review from a team July 18, 2022 18:49
@downsrob downsrob merged commit 25be3d9 into opensearch-project:1.3 Jul 18, 2022
@downsrob downsrob deleted the js-zip-backport branch July 18, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants