Only download JS zip when integTest is running #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
thalurur
reviewed
Apr 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
============================================
+ Coverage 76.60% 76.79% +0.19%
+ Complexity 2050 2049 -1
============================================
Files 253 253
Lines 11642 11642
Branches 1808 1808
============================================
+ Hits 8918 8941 +23
+ Misses 1753 1733 -20
+ Partials 971 968 -3
Continue to review full report at Codecov.
|
|
Interesting that bwc test success on my local while instantly fail in github actions. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
force-pushed
the
opensearch-2.0.0-download-js-zip-only-in-integTest
branch
from
873c7c0 to
1e5faa0
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
dblock
approved these changes
Apr 15, 2022
downsrob
approved these changes
Apr 15, 2022
1 task
peterzhuamazon
deleted the
opensearch-2.0.0-download-js-zip-only-in-integTest
branch
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
* Move download into integTest task section Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Make sure the zip only download when integTest runs Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Make sure all 3 artifacts are downloaded during bwc test Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Make sure the zip only download when integTest runs Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Make sure all 3 artifacts are downloaded during bwc test Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more changes Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * More tweaks Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Issue #, if available:
#333
Description of changes:
Only download JS zip when integTest is running
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.