Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] bump ktlint 1.1.0 to 1.5.0 #1338

Merged
merged 2 commits into from
Jan 19, 2025
Merged

[Backport 2.x] bump ktlint 1.1.0 to 1.5.0 #1338

merged 2 commits into from
Jan 19, 2025

Conversation

shiv0408
Copy link
Member

cherry-pick f8889e6 from #1336

@shiv0408
bump ktlint from 1.1.0 to 1.5.0 (opensearch-project#1336)
d7c6991 
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
vikasvb90
vikasvb90 reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@vikasvb90 vikasvb90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflows are failing:

Summary error count (descending) by rule:
  standard:no-trailing-spaces: 7
  standard:trailing-comma-on-declaration-site: 6
  standard:parameter-list-spacing: 5

@shiv0408
appease ktlint
d1e040e 
Signed-off-by: Shivansh Arora <hishiv@amazon.com>

.

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@shiv0408 shiv0408 force-pushed the backport/backport-1336-to-2.x branch from 1338d41 to d1e040e Compare January 15, 2025 07:20
@Hailong-am
Copy link
Collaborator

let's wait for all CIs are passed

@shiv0408 shiv0408 requested a review from vikasvb90 January 19, 2025 12:27
@shiv0408 shiv0408 merged commit 49da816 into opensearch-project:2.x Jan 19, 2025
28 checks passed
@shiv0408 shiv0408 deleted the backport/backport-1336-to-2.x branch January 19, 2025 12:27
@shiv0408
Copy link
Member Author

Merged as all CIs passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@bowenlan-amzn bowenlan-amzn Awaiting requested review from bowenlan-amzn bowenlan-amzn is a code owner

@tandonks tandonks Awaiting requested review from tandonks tandonks is a code owner

@soosinha soosinha Awaiting requested review from soosinha soosinha is a code owner

@vikasvb90 vikasvb90 Awaiting requested review from vikasvb90 vikasvb90 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiv0408 @Hailong-am @vikasvb90