Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering in transforms UI #179

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

thalurur
Copy link
Contributor

@thalurur thalurur commented Apr 18, 2022

Signed-off-by: Ravi Thaluru thalurur@users.noreply.github.com

Description

Fix geopoint rendering issue
Earlier if geopoint data type is selected in opensearch sample flight data for example when geopoint data type e.g DestLocation is selected then whole page crashes

image
image

After fix the geopoint is rendered as a string
image
image

render alias fields correctly
imageimage

Rendering sparse data correctly
image

Issues Resolved

#141
#134

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@thalurur thalurur requested a review from a team April 18, 2022 20:51
@thalurur thalurur marked this pull request as draft April 18, 2022 20:51
@thalurur thalurur changed the title Fix GeoPoint cell rendering in transforms UI Fix rendering in transforms UI Apr 19, 2022
2. Not populating alias fields in the preview table of transforms
3. Render sparse data correctly

Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@thalurur thalurur marked this pull request as ready for review April 19, 2022 08:04
dbbaughe
dbbaughe previously approved these changes Apr 19, 2022
@thalurur thalurur dismissed stale reviews from dbbaughe and praveensameneni via 7ddd7e7 April 19, 2022 17:53
…ctual column they are representing

Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #179 (4130a1c) into main (85f8e13) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   62.28%   62.22%   -0.06%     
==========================================
  Files         156      156              
  Lines        4552     4556       +4     
  Branches      718      717       -1     
==========================================
  Hits         2835     2835              
- Misses       1500     1504       +4     
  Partials      217      217              
Impacted Files Coverage Δ
...m/components/DefineTransforms/DefineTransforms.tsx 69.64% <0.00%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f8e13...4130a1c. Read the comment docs.

@thalurur thalurur merged commit 30e2f67 into opensearch-project:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants