Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in transform API validation to support index patterns #1237

Merged
merged 5 commits into from
Jan 19, 2025

Conversation

tandonks
Copy link
Collaborator

@tandonks tandonks commented Dec 26, 2024

Description

Fixing #1224

Issues Resolved

Resolves #1224

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bowenlan-amzn
bowenlan-amzn previously approved these changes Dec 26, 2024
Hailong-am
Hailong-am previously approved these changes Dec 27, 2024
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test to cover this change?

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
@tandonks tandonks dismissed stale reviews from bowenlan-amzn and Hailong-am via fa33bd5 January 18, 2025 12:20
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Member

@shiv0408 shiv0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing and adding an integration test 🙌

@shiv0408 shiv0408 merged commit bed34dd into opensearch-project:main Jan 19, 2025
10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1237-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bed34ddf5e709ba75c77412bb36231c0c953b1ca
# Push it to GitHub
git push --set-upstream origin backport/backport-1237-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1237-to-2.x.

tandonks added a commit to tandonks/index-management-dashboards-plugin that referenced this pull request Jan 19, 2025
…nsearch-project#1237)

* Fixing bug in transform API validation

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding test for creating transform job using wildcard

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Retracting a change which was for testing only

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing an issue with the delete test of transform

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Modifying transform test

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
shiv0408 pushed a commit that referenced this pull request Jan 20, 2025
…x patterns (#1237) (#1241)

* Fixing bug in transform API validation to support index patterns (#1237)

* Fixing bug in transform API validation

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding test for creating transform job using wildcard

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Retracting a change which was for testing only

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing an issue with the delete test of transform

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Modifying transform test

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Removing an unintended change while resolving conflict

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to create Transform Job using UI for index patterns
4 participants