Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate latest DatasourceMenu props into index-management MDS support #1030

Conversation

CaptainDredge
Copy link
Contributor

@CaptainDredge CaptainDredge commented Apr 11, 2024

Description

This PR updates index-management dashboard with the latest changes of data source picker component and removes dataSourceLabel from the URL

Issues Resolved

Resolves #1028

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
@BionIT
Copy link

BionIT commented Apr 14, 2024

Thanks @CaptainDredge for the change! Noticed 3 pages don't have the data source id in the url

  1. notification - is it owned by a different plugin?
    Screenshot from 2024-04-14 16-34-35

  2. templates
    Screenshot from 2024-04-14 16-34-08

  3. data streams
    Screenshot from 2024-04-14 16-34-18

Will they be fixed in another PR?

Another thing noticed is the datasourceId in the url is set to empty string instead of the default data source thus in Neo use case, it would fail on initial load until user makes a different choice. To verify, use the recent main branch and switch the config in yaml data_source.hideLocalCluster: true

@CaptainDredge
Copy link
Contributor Author

notification - is it owned by a different plugin?

@BionIT Yes it is owned by notification plugin team owned by @praveensameneni

Template and datastreams are owned by us and recent changes in main should now have the datasourceId

To verify, use the recent main branch and switch the config in yaml data_source.hideLocalCluster: true

Recently, PR #1036 got merged in Main, can you check once if this behaviour still exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking Issue] Integrate latest changes of data source picker components to index-managment dashboard plugin
2 participants