Add lifecycle hooks to opensearch dashboard helm chart #145

bluehawk27 · 2021-11-24T23:31:20Z

Description

[Describe what this change achieves]
Adds lifcycle hook that is currently supported in the helm template https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch-dashboards/templates/deployment.yaml#L140

Issues Resolved

[List any issues this PR will resolve]
#144

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…roject#139) * Fix url to values.yaml in README.md in opensearch chart Signed-off-by: Dmytro Gorbunov <dmytro.gorbunov@gmail.com> * Make URL to values.yaml in README.md more consistent (with reference section) Signed-off-by: Dmytro Gorbunov <dmytro.gorbunov@gmail.com> * Increment the Chart version and update the Changelog Signed-off-by: Dmytro Gorbunov <dmytro.gorbunov@gmail.com> * Update version of opensearch chart after resolving merge conflict Signed-off-by: Dmytro Gorbunov <dmytro.gorbunov@gmail.com> Co-authored-by: Dmytro Gorbunov <dmytro.gorbunov@gmail.com> Signed-off-by: bluehawk27 <alberto@doc.ai>

Signed-off-by: bluehawk27 <alberto@doc.ai>

charts/opensearch-dashboards/values.yaml

charts/opensearch/CHANGELOG.md

peterzhuamazon · 2021-11-29T22:30:20Z

Hi @bluehawk27 this is a change in dashboards but your version bump and change logs are modified in opensearch. Can you correct this in the corresponding files of opensearch-dashboards folder?

Thanks.

DandyDeveloper

Looks great, but I have some requests.

Only other thing - We need to add the values for the lifecycle to the README.md

charts/opensearch-dashboards/values.yaml

charts/opensearch/CHANGELOG.md

Signed-off-by: bluehawk27 <alberto@doc.ai>

peterzhuamazon · 2021-12-06T18:17:11Z

Seeing a lot of conflicts here.
Can you try to resolve them @bluehawk27 ?
Thanks.

DandyDeveloper · 2021-12-09T01:01:25Z

I neglected to follow up on this. If @bluehawk27 doesn't get a chance I'll fix the conflicts tomorrow.

bluehawk27 · 2021-12-10T16:26:03Z

@DandyDeveloper @peterzhuamazon does every PR require a chart version bump? This PR doesn't materially change the chart behavior. It more or less just documents existing behavior.

peterzhuamazon · 2021-12-10T18:23:47Z

@DandyDeveloper @peterzhuamazon does every PR require a chart version bump? This PR doesn't materially change the chart behavior. It more or less just documents existing behavior.

Yes @bluehawk27
#152 (comment)

bluehawk27 · 2021-12-16T18:05:29Z

ok thank you for answering @peterzhuamazon . I can't keep resolving conflicts every time another PR gets merged in before this one so let me know when you plan on merging it in and I'll do a version bump.

peterzhuamazon · 2021-12-16T18:56:58Z

ok thank you for answering @peterzhuamazon . I can't keep resolving conflicts every time another PR gets merged in before this one so let me know when you plan on merging it in and I'll do a version bump.

Reserve 1.5.8 for you @bluehawk27 we are also trying to improve the process, sorry about confusion.
We will merge your PR once #159 #84 #179 merged.

Thanks.

peterzhuamazon · 2022-02-03T01:00:16Z

@DandyDeveloper @TheAlgo please look at this PR and see if @bluehawk27 has resolved all issues.
Once you guys approve I will fix the versions and merge it.

Thanks.

peterzhuamazon · 2022-02-20T16:58:42Z

@DandyDeveloper @TheAlgo poke on this PR again as it sits for a while.
Could you guys check the code and see if we can proceed?
Ignore version conflicts.

Thanks.

NybbleHub · 2022-04-01T15:43:06Z

Hi guys,

Any news on this pull request ? Could be really good to have lifecycle block :)

Thanks !

peterzhuamazon · 2022-04-01T17:35:43Z

Adding @prudhvigodithi to take a look on this.

TheAlgo · 2022-04-01T18:38:12Z

Apologies @bluehawk27 , this got completely missed. Could you resolve the conversations for the comments you have addressed? We can take care of the conflicts and chart bumps

bluehawk27 · 2022-04-25T18:23:07Z

@TheAlgo I resolved the convo's :) hope that helps move this forward. Cheers

peterzhuamazon · 2022-04-25T23:32:56Z

Hi @DandyDeveloper @TheAlgo @prudhvigodithi please review again, I will resolve the version conflicts once you guys are good.
Thanks.

prudhvigodithi · 2022-07-06T13:27:38Z

LGTM!

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon · 2022-07-07T23:56:17Z

Hi @bluehawk27 I have rebased your branch on main and remove the opensearch changelogs as only dashboards get changed with lifecycle hooks.

@TheAlgo @DandyDeveloper @prudhvigodithi please review.

Thanks.

Signed-off-by: pgodithi <pgodithi@amazon.com>

prudhvigodithi · 2022-07-08T14:23:11Z

Hey @bluehawk27 I have done an upstream fetch and merge, to keep the versions in consistent with yesterday's release PR
#283, additionally I have fixed some lint error.

prudhvigodithi · 2022-07-08T14:24:54Z

LGTM @DandyDeveloper and @TheAlgo please review.
Thank you

TheAlgo

LGTM!

TheAlgo

Can we add this option in the README as well before merging? @bluehawk27 Let me know if that sounds good. Thanks

TheAlgo · 2022-07-19T19:49:39Z

Any update on this @bluehawk27 ?

peterzhuamazon · 2022-08-02T16:10:29Z

I am going to add to readme and resolve conflict/backport @TheAlgo @prudhvigodithi

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

charts/opensearch-dashboards/README.md

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon · 2022-08-02T20:10:57Z

Backport 1.x: #305

Thanks @bluehawk27 for the contribution and sorry for the delay.

Thanks.

* Backport 1.x from #145 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Empty commit Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Alberto Villacorta <avillacorta27@gmail.com>

bluehawk27 force-pushed the main branch from 9f06f0a to 7a9b3a8 Compare November 24, 2021 23:35

gdm and others added 2 commits November 24, 2021 15:37

Add lifecycle hooks to opensearch dashboard helm chart

da6340d

Signed-off-by: bluehawk27 <alberto@doc.ai>

bluehawk27 force-pushed the main branch from 7a9b3a8 to da6340d Compare November 24, 2021 23:37

TheAlgo reviewed Nov 26, 2021

View reviewed changes

charts/opensearch-dashboards/values.yaml Outdated Show resolved Hide resolved

charts/opensearch/CHANGELOG.md Outdated Show resolved Hide resolved

peterzhuamazon linked an issue Nov 29, 2021 that may be closed by this pull request

[Enhancement][opensearch-dashboards] Add lifecycle: block to values file #144

Closed

peterzhuamazon requested a review from DandyDeveloper November 29, 2021 22:27

DandyDeveloper requested changes Nov 30, 2021

View reviewed changes

charts/opensearch-dashboards/values.yaml Show resolved Hide resolved

charts/opensearch-dashboards/values.yaml Show resolved Hide resolved

charts/opensearch/CHANGELOG.md Outdated Show resolved Hide resolved

bluehawk27 added 2 commits November 30, 2021 10:25

bump version and add changes to changelog

27a0eba

Signed-off-by: bluehawk27 <alberto@doc.ai>

move change to correct version in changelog

96896d5

Signed-off-by: bluehawk27 <alberto@doc.ai>

Merge branch 'main' into main

de312ae

peterzhuamazon requested review from TheAlgo, DandyDeveloper and prudhvigodithi April 1, 2022 17:35

peterzhuamazon self-requested a review April 25, 2022 23:31

Rebase on main

77dc347

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

bluehawk27 requested a review from a team as a code owner July 7, 2022 23:52

peterzhuamazon added 3 commits July 7, 2022 19:53

Rebase on main

eb50a8a

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Rebase on main

a5317aa

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Rebase on main

b456395

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

prudhvigodithi added 2 commits July 8, 2022 10:17

Upstream fetch and version update to [2.0.1]

adc7262

Signed-off-by: pgodithi <pgodithi@amazon.com>

Upstream fetch and version update to [2.0.1], fix lint errors

5775432

Signed-off-by: pgodithi <pgodithi@amazon.com>

prudhvigodithi approved these changes Jul 8, 2022

View reviewed changes

TheAlgo approved these changes Jul 10, 2022

View reviewed changes

TheAlgo reviewed Jul 10, 2022

View reviewed changes

DandyDeveloper approved these changes Jul 21, 2022

View reviewed changes

peterzhuamazon added 2 commits August 2, 2022 15:02

Update version and readme and sync from main

080b91b

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Update version and readme and sync from main

68fc25e

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

prudhvigodithi reviewed Aug 2, 2022

View reviewed changes

charts/opensearch-dashboards/README.md Show resolved Hide resolved

peterzhuamazon merged commit 8f08e77 into opensearch-project:main Aug 2, 2022

peterzhuamazon pushed a commit to peterzhuamazon/helm-charts that referenced this pull request Aug 2, 2022

Backport 1.x from opensearch-project#145

8dbf2d0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon mentioned this pull request Aug 2, 2022

[Backport 1.x] Helm charts #145 backport 1.x #305

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lifecycle hooks to opensearch dashboard helm chart #145

Add lifecycle hooks to opensearch dashboard helm chart #145

bluehawk27 commented Nov 24, 2021 •

edited

Loading

peterzhuamazon commented Nov 29, 2021

DandyDeveloper left a comment

peterzhuamazon commented Dec 6, 2021

DandyDeveloper commented Dec 9, 2021

bluehawk27 commented Dec 10, 2021

peterzhuamazon commented Dec 10, 2021

bluehawk27 commented Dec 16, 2021

peterzhuamazon commented Dec 16, 2021

peterzhuamazon commented Feb 3, 2022

peterzhuamazon commented Feb 20, 2022

NybbleHub commented Apr 1, 2022

peterzhuamazon commented Apr 1, 2022

TheAlgo commented Apr 1, 2022

bluehawk27 commented Apr 25, 2022

peterzhuamazon commented Apr 25, 2022

prudhvigodithi commented Jul 6, 2022

peterzhuamazon commented Jul 7, 2022

prudhvigodithi commented Jul 8, 2022

prudhvigodithi commented Jul 8, 2022

TheAlgo left a comment

TheAlgo left a comment •

edited

Loading

TheAlgo commented Jul 19, 2022

peterzhuamazon commented Aug 2, 2022

peterzhuamazon commented Aug 2, 2022

Add lifecycle hooks to opensearch dashboard helm chart #145

Add lifecycle hooks to opensearch dashboard helm chart #145

Conversation

bluehawk27 commented Nov 24, 2021 • edited Loading

Description

Issues Resolved

Check List

peterzhuamazon commented Nov 29, 2021

DandyDeveloper left a comment

Choose a reason for hiding this comment

peterzhuamazon commented Dec 6, 2021

DandyDeveloper commented Dec 9, 2021

bluehawk27 commented Dec 10, 2021

peterzhuamazon commented Dec 10, 2021

bluehawk27 commented Dec 16, 2021

peterzhuamazon commented Dec 16, 2021

peterzhuamazon commented Feb 3, 2022

peterzhuamazon commented Feb 20, 2022

NybbleHub commented Apr 1, 2022

peterzhuamazon commented Apr 1, 2022

TheAlgo commented Apr 1, 2022

bluehawk27 commented Apr 25, 2022

peterzhuamazon commented Apr 25, 2022

prudhvigodithi commented Jul 6, 2022

peterzhuamazon commented Jul 7, 2022

prudhvigodithi commented Jul 8, 2022

prudhvigodithi commented Jul 8, 2022

TheAlgo left a comment

Choose a reason for hiding this comment

TheAlgo left a comment • edited Loading

Choose a reason for hiding this comment

TheAlgo commented Jul 19, 2022

peterzhuamazon commented Aug 2, 2022

peterzhuamazon commented Aug 2, 2022

bluehawk27 commented Nov 24, 2021 •

edited

Loading

TheAlgo left a comment •

edited

Loading