[Feature/agent_framework] Work around JceMasterKey locale bug #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Dec 2, 2023
owaiskazi19
approved these changes
Dec 2, 2023
owaiskazi19
merged commit c35a809
into
opensearch-project:feature/agent_framework
10 checks passed
This was referenced Dec 2, 2023
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 9, 2023
…arch-project#239) Work around JceMasterKey locale bug Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 13, 2023
…terKey locale bug (#239) (#285) [Port from Feature/agent_framework] Work around JceMasterKey locale bug (#239) (#269) [Feature/agent_framework] Work around JceMasterKey locale bug (#239) Work around JceMasterKey locale bug (cherry picked from commit 72131bb) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Works around an upstream bug where Locale is ignored in a string uppercase conversion by starting out with the string in upper case.
No guarantee it will totally fix the problem but should mitigate it. Bug also filed upstream at aws/aws-encryption-sdk-java#1879
Issues Resolved
Fixes #233
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.