[Backport 2.x] Implement multi tenancy in Flow Framework (#980) #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Import SdkClient and inject it Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass sdkClient to IndicesHandler and EncryptorUtils classes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Extract tenant id from REST header into RestAction Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass tenant id to transport actions in template Signed-off-by: Daniel Widdis <widdis@gmail.com> * Validate tenant id existence in workflow transport actions Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass SdkClient and tenant id to util used for access control checks Signed-off-by: Daniel Widdis <widdis@gmail.com> * Perform tenant id validation checks for workflow APIs Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate Update workflow get action to SdkCleint Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass tenantId to IndicesHandler and use in EncryptorUtils Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate EncryptorUtils getting master key from index Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor fetching master key to permit reuse Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor initializeMasterKey to use common code Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate indexing new key to config Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate template indexing to sdkClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate template deletion to sdkClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate get template to sdkClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate provision template to sdkClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate max workflow search to sdkClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tenantId to GetWorkflowStateRequest Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate GetWorkflowStateRequest to multitenant client Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate getProvisioningProgress to avoid repetition Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate canDeleteWorkflowStateDoc to avoid repetition Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate initial state document creation to metadata client Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate state document deletion to metadata client Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add Tenant aware Rest Tests for Workflows Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix javadocs Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add publishToMavenLocal for more CI Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix some CI Signed-off-by: Daniel Widdis <widdis@gmail.com> * Enable tenant aware search Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor state index update method using multitenant client Signed-off-by: Daniel Widdis <widdis@gmail.com> * Get metadata client artifacts from Maven Snapshot Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests for new update async code Signed-off-by: Daniel Widdis <widdis@gmail.com> * Switch SdkClient to use default generic thread executor Signed-off-by: Daniel Widdis <widdis@gmail.com> * Migrate last updates to sdkClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Revert (most) changes to unit tests based on async client changes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Pass tenant id when updating state during provisioning Signed-off-by: Daniel Widdis <widdis@gmail.com> * Integrate tenantId with synchronous provisioning Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix failing integ tests after rebase, code review updates Signed-off-by: Daniel Widdis <widdis@gmail.com> * Replace fakeTenantId placeholders with actual tenant id Signed-off-by: Daniel Widdis <widdis@gmail.com> * Use version catalog for commons-lang3 and httpcore dependencies Signed-off-by: Daniel Widdis <widdis@gmail.com> * Exclude transitive httpclient dependency from metadata and rest client Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix more test errors and tweak dependencies Signed-off-by: Daniel Widdis <widdis@gmail.com> * More code review comments and refactoring Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
amitgalitz
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports d8a5a4b from #980