Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds link to Maven repo and updates plugins list with Geospatial #999

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

JeffHuss
Copy link

Signed-off-by: JeffH-AWS jeffhuss@amazon.com

Description

Added link to the official Maven repo, and added Geospatial to the list of official plugins.

Issues Resolved

Fixes #998
Fixes #838

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
@JeffHuss JeffHuss requested a review from a team as a code owner August 25, 2022 16:28
@JeffHuss JeffHuss added the 4 - Doc review PR: Doc review in progress label Aug 25, 2022
@JeffHuss JeffHuss self-assigned this Aug 25, 2022
@JeffHuss JeffHuss added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 v-All This issue is valid for all versions through 1.3 3 - Tech review PR: Tech review in progress and removed 3 - Tech review PR: Tech review in progress labels Aug 25, 2022
@Naarcha-AWS Naarcha-AWS added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 and removed backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 labels Aug 25, 2022
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffHuss JeffHuss merged commit a39e2c4 into main Aug 25, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)
@JeffHuss JeffHuss deleted the add-maven-coords-838 branch August 25, 2022 16:54
JeffHuss pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999) (#1003)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)

Co-authored-by: Jeff Huss <jeffhuss@amazon.com>
JeffHuss pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999) (#1002)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)

Co-authored-by: Jeff Huss <jeffhuss@amazon.com>
JeffHuss pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999) (#1001)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)

Co-authored-by: Jeff Huss <jeffhuss@amazon.com>
Naarcha-AWS pushed a commit that referenced this pull request Aug 25, 2022
…ial (#999) (#1000)

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
(cherry picked from commit a39e2c4)

Co-authored-by: Jeff Huss <jeffhuss@amazon.com>
@@ -25,7 +25,7 @@ If you are running OpenSearch in a Docker container, plugins must be installed,
The install command takes a plugin id, which may be any of the following:

- An official OpenSearch plugin name
- Maven coordinates to a plugin zip file
- [Maven coordinates](https://mvnrepository.com/artifact/org.opensearch.plugin) to a plugin zip file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffH-AWS:

i just saw these docs for the first time.

please note that this is not correct (unless somebody just added that feature? but i haven't seen anything in these regards)! opensearch-plugin install does not accept maven coordinates. you cannot e.g. write opensearch-plugin install org.opensearch.plugin:opensearch-security:2.2.0.0! (though you could of course use the normal HTTP URL of that maven artefact, but then it's irrelevant that it's on maven)

the usage for maven here is in combination with automated build systems which need to fetch the artefacts (often through proxies in company environments), cache them and then later feed them to a build (e.g. docker build) which takes them as normal files and calls the install command with a file:/// path

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the blog post might contain further information relevant for you as it describes how the maven artefacts can be used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling that out Ralph! I was not aware that the original documentation was also inaccurate - nobody has raised an issue on that. Would you mind opening a new issue? You can even assign it to me, if that's something you're able to do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np. i've raised #1007. i don't have the rights to assign it to you, though.

@JeffHuss JeffHuss removed the 4 - Doc review PR: Doc review in progress label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 v-All This issue is valid for all versions through 1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add Geospatial to plugins list [BUG] Add Maven coordinates to list of available plugins
5 participants