-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds link to Maven repo and updates plugins list with Geospatial #999
Conversation
Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -25,7 +25,7 @@ If you are running OpenSearch in a Docker container, plugins must be installed, | |||
The install command takes a plugin id, which may be any of the following: | |||
|
|||
- An official OpenSearch plugin name | |||
- Maven coordinates to a plugin zip file | |||
- [Maven coordinates](https://mvnrepository.com/artifact/org.opensearch.plugin) to a plugin zip file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffH-AWS:
i just saw these docs for the first time.
please note that this is not correct (unless somebody just added that feature? but i haven't seen anything in these regards)! opensearch-plugin install
does not accept maven coordinates. you cannot e.g. write opensearch-plugin install org.opensearch.plugin:opensearch-security:2.2.0.0
! (though you could of course use the normal HTTP URL of that maven artefact, but then it's irrelevant that it's on maven)
the usage for maven here is in combination with automated build systems which need to fetch the artefacts (often through proxies in company environments), cache them and then later feed them to a build (e.g. docker build) which takes them as normal files and calls the install command with a file:///
path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the blog post might contain further information relevant for you as it describes how the maven artefacts can be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for calling that out Ralph! I was not aware that the original documentation was also inaccurate - nobody has raised an issue on that. Would you mind opening a new issue? You can even assign it to me, if that's something you're able to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np. i've raised #1007. i don't have the rights to assign it to you, though.
Signed-off-by: JeffH-AWS jeffhuss@amazon.com
Description
Added link to the official Maven repo, and added Geospatial to the list of official plugins.
Issues Resolved
Fixes #998
Fixes #838
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.