Improved shard allocation awareness attributes documentation #8268
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patelsmit32123
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@RS146BIJAY please review the documentation changes too |
patelsmit32123
force-pushed
the
improve-shard-allocation-awareness-docs
branch
2 times, most recently
from
f1c568e
to
8c4ea94
Compare
patelsmit32123
force-pushed
the
improve-shard-allocation-awareness-docs
branch
from
8c4ea94
to
43a61f7
Compare
Signed-off-by: Smit Patel <psmit@uber.com>
patelsmit32123
force-pushed
the
improve-shard-allocation-awareness-docs
branch
from
43a61f7
to
e8a513a
Compare
|
@natebower can you please review? |
|
|
@patelsmit32123: I'll take a look at this today. |
Naarcha-AWS
added
backport 2.17
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Smit Patel <psmit@uber.com>
patelsmit32123
force-pushed
the
improve-shard-allocation-awareness-docs
branch
from
0ac6956
to
2b931de
Compare
Naarcha-AWS
reviewed
Sep 17, 2024
Naarcha-AWS
reviewed
Sep 17, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
added
5 - Editorial review
|
@natebower: Ready for editorial. |
natebower
reviewed
Sep 17, 2024
There was a problem hiding this comment.
@Naarcha-AWS @patelsmit32123 Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
approved these changes
Sep 17, 2024
|
@patelsmit32123: We'll merge this in after the release later this afternoon. |
natebower
added
6 - Done but waiting to merge
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Added more details regarding shard allocation awareness attributes Signed-off-by: Smit Patel <psmit@uber.com> * Update index.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Addressed linter recommendations Signed-off-by: Smit Patel <psmit@uber.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _tuning-your-cluster/index.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: Smit Patel <psmit@uber.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Smit Patel <39486815+patelsmit32123@users.noreply.github.com> Co-authored-by: Smit Patel <psmit@uber.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit ac40282) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shard allocation awareness attributes documentation was lacking information regarding how the allocation actually functions and in what conditions the shard can remain unallocated.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.