-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document '_name' field in 'function_score' query's function definition #7340
Conversation
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
@lrynek - Let us know when the content is ready for review. Perhaps @reta can do a tech review? I've added @kolchfa-aws as the doc lead who can help with the review process. Thanks! |
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
@hdhalter @kolchfa-aws @reta Thanks for your patience - I've finally found a spare moment to install the latest OpenSearch (2.15.1) on my machine to prepare real |
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @lrynek! Just a couple of comments, and we'll be ready to put the PR through editorial review and then merge.
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com>
@kolchfa-aws ✅ Everything applied, thank you for a thorough review👌🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws @lrynek Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com>
@natebower LGTM - I've just implemented your suggestions 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#7340) * Document '_name' field in 'function_score' query function definition Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real request JSON payload Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real response JSON payload + finish the paragraph Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing copy-curl tag Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing article Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> --------- Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit b0ebb50) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project#7340) * Document '_name' field in 'function_score' query function definition Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real request JSON payload Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real response JSON payload + finish the paragraph Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing copy-curl tag Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing article Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> --------- Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
opensearch-project#7340) * Document '_name' field in 'function_score' query function definition Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real request JSON payload Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real response JSON payload + finish the paragraph Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing copy-curl tag Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing article Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> --------- Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sander van de Geijn <sandervandegeijn@icloud.com>
Description
Document
_name
field infunction_score
query's function definition introduced in opensearch-project/OpenSearch#1711 and demanded in the issue #432Issues Resolved
Closes #432
Version
All versions.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.