Document '_name' field in 'function_score' query's function definition #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
lrynek
commented
Jun 9, 2024
|
@lrynek - Let us know when the content is ready for review. Perhaps @reta can do a tech review? I've added @kolchfa-aws as the doc lead who can help with the review process. Thanks! |
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
lrynek
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
@hdhalter @kolchfa-aws @reta Thanks for your patience - I've finally found a spare moment to install the latest OpenSearch (2.15.1) on my machine to prepare real |
Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com>
reta
approved these changes
Jul 4, 2024
hdhalter
added
4 - Doc review
kolchfa-aws
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thanks so much, @lrynek! Just a couple of comments, and we'll be ready to put the PR through editorial review and then merge.
kolchfa-aws
reviewed
Jul 5, 2024
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com>
@kolchfa-aws ✅ Everything applied, thank you for a thorough review👌🏻 |
natebower
reviewed
Jul 9, 2024
There was a problem hiding this comment.
@kolchfa-aws @lrynek Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com>
@natebower LGTM - I've just implemented your suggestions 👍🏻 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
#7340) * Document '_name' field in 'function_score' query function definition Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real request JSON payload Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real response JSON payload + finish the paragraph Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing copy-curl tag Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing article Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> --------- Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit b0ebb50) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
opensearch-project#7340) * Document '_name' field in 'function_score' query function definition Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real request JSON payload Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real response JSON payload + finish the paragraph Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing copy-curl tag Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing article Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> --------- Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
opensearch-project#7340) * Document '_name' field in 'function_score' query function definition Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real request JSON payload Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Ensure real response JSON payload + finish the paragraph Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing copy-curl tag Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Add missing article Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> --------- Signed-off-by: Łukasz Rynek <lukasz.rynek@gmail.com> Signed-off-by: Łukasz Rynek <36886649+lrynek@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sander van de Geijn <sandervandegeijn@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document
_namefield infunction_scorequery's function definition introduced in opensearch-project/OpenSearch#1711 and demanded in the issue #432Issues Resolved
Closes #432
Version
All versions.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.