Moving cluster indices permission to cluster section #1656 #7161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#1656 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Converted to draft, as found permissions in Dashboards UI that user can only add as cluster, but should be added as index permission, indices:data/write/bulk* |
hdhalter
added
security
backport 2.14
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
hdhalter
added
3 - Tech review
|
While working on this PR I came across incorrect/outdated API documentation and raised issue to fix it: |
stephen-crawford
approved these changes
May 24, 2024
hdhalter
added
4 - Doc review
Naarcha-AWS
requested changes
May 28, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
|
@Naarcha-AWS , if this looks good, it can go to Nathan. An editorial request has already been submitted. |
Naarcha-AWS
approved these changes
May 29, 2024
Naarcha-AWS
reviewed
May 29, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
added
5 - Editorial review
|
@natebower: This is ready for editorial review. |
natebower
reviewed
Jun 5, 2024
There was a problem hiding this comment.
@AntonEliatra @Naarcha-AWS Please see my changes and confirm the phrasing I've flagged on lines 193 and 514. Thanks!
| | `indices:data/read/scroll` | Permission to scroll data. | | ||
| | `indices:data/read/scroll/clear` | Permission to clear read scroll data. | | ||
| | `indices:data/read/scroll` | Permission to scroll data. This setting needs to be configured as both a cluster and index level permission. | | ||
| | `indices:data/read/scroll/clear` | Permission to clear read scroll data. This setting needs to be configured as both a cluster and index level permission. | |
There was a problem hiding this comment.
Is "read scroll data" a thing?
There was a problem hiding this comment.
hey @natebower I'm not sure I follow, You mean read/scroll to scroll through data/results or read/scroll/data - which I haven't come across
There was a problem hiding this comment.
@AntonEliatra I suspect that "read scroll data" is meant to be past tense, but it reads as though "read scroll data" is a noun. Can we rephrase for clarity?
There was a problem hiding this comment.
Ah I see what you mean, will fix now
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
natebower
requested changes
Jun 5, 2024
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
natebower
reviewed
Jun 5, 2024
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
natebower
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Moving cluster indices permission to cluster section #1656 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * updating index and cluster permissions Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * removing empty space Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * fixing vale errors Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * adding more permissions to the list Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update permissions.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update _security/access-control/permissions.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 88bab65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving cluster wide Index permissions to cluster permission section
Issues Resolved
Closes #2359
Closes #1656
Closes #621
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.