Update SAML tutorial with new default Admin settings #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
requested review from
hdhalter,
kolchfa-aws,
vagimeli,
AMoo-Miki,
natebower and
dlvenable
as code owners
1 task
| @@ -34,20 +34,20 @@ We provide a fully functional example that can help you understand how to use SA | |||
|
|
|||
| ```yml | |||
| opensearch-saml-node1: | |||
| image: opensearchproject/opensearch:2.8.0 | |||
| image: opensearchproject/opensearch:2.12.0 | |||
There was a problem hiding this comment.
we should change version on line 33 as well since it points to 2.6
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
|
@DarshitChanpura: I went ahead and used our site variable here so it'll update to whatever version the user is on currently. |
DarshitChanpura
approved these changes
Jan 30, 2024
2 tasks
Naarcha-AWS
added
4 - Doc review
hdhalter
added
the
release-notes
Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
added
6 - Done but waiting to merge
hdhalter
added
3 - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SAML tutorial based off of PR #5887
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.