Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add threat intelligence for 2.12 #6273
Add threat intelligence for 2.12 #6273
Changes from 5 commits
6e35b36
56a5ac0
9a4fb2b
fab0740
f06b90f
95ba740
52a3a30
52c5da2
ab8f3b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include a link to the spec?
Check failure on line 138 in _security-analytics/sec-analytics-config/detectors-config.md
GitHub Actions / vale
[vale] _security-analytics/sec-analytics-config/detectors-config.md#L138
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"specified" instead of "specific"?
Check failure on line 141 in _security-analytics/sec-analytics-config/detectors-config.md
GitHub Actions / vale
[vale] _security-analytics/sec-analytics-config/detectors-config.md#L141
Raw output
Check failure on line 145 in _security-analytics/sec-analytics-config/detectors-config.md
GitHub Actions / vale
[vale] _security-analytics/sec-analytics-config/detectors-config.md#L145
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazon Route 53 is a service, not a log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of the last sentence here (or my rewrite), as it's a little ambiguous. Can we be more specific about what we mean by "critical information"? In other words, what information exactly is called an IoC (what makes it critical)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we can't change this at the moment, but just FYI, it should be "threat-intelligence-based detection".