Added documentation for changing the default values of HNSW hyper parameters in k-NN plugin #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower and
dlvenable
as code owners
4 tasks
|
Thanks, @navneet1v ! Is this PR ready for doc review? |
hdhalter
added
release-notes
|
@hdhalter yes it is. |
kolchfa-aws
approved these changes
Jan 29, 2024
navneet1v
force-pushed
the
main
branch
3 times, most recently
from
d982c38
to
f38495d
Compare
natebower
reviewed
Jan 30, 2024
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
navneet1v
force-pushed
the
main
branch
2 times, most recently
from
71d71b9
to
05a60a3
Compare
|
@natebower I fixed all your comments. Please review. |
natebower
added
5 - Editorial review
natebower
reviewed
Jan 31, 2024
natebower
approved these changes
Jan 31, 2024
kolchfa-aws
added
6 - Done but waiting to merge
|
@navneet1v Thank you! This PR is ready; we'll merge it closer to the release. |
…meters in k-NN plugin Signed-off-by: Navneet Verma <navneev@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
hdhalter
added
3 - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for changing the default values of HNSW hyper parameters in k-NN plugin
Issues Resolved
Resolves #6021
k-NN plugin issue: opensearch-project/k-NN#1354
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.