-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for changing the default values of HNSW hyper parameters in k-NN plugin #6272
Conversation
Thanks, @navneet1v ! Is this PR ready for doc review? |
@hdhalter yes it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @navneet1v! A couple of rewrites.
d982c38
to
f38495d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
71d71b9
to
05a60a3
Compare
@natebower I fixed all your comments. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navneet1v @kolchfa-aws Just one change. Otherwise, LGTM.
@navneet1v Thank you! This PR is ready; we'll merge it closer to the release. |
…meters in k-NN plugin Signed-off-by: Navneet Verma <navneev@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Description
Added documentation for changing the default values of HNSW hyper parameters in k-NN plugin
Issues Resolved
Resolves #6021
k-NN plugin issue: opensearch-project/k-NN#1354
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.