Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify global and primary tenant functionality - issue 488 #508

Merged
merged 5 commits into from
Apr 14, 2022

Conversation

alicejw1
Copy link
Contributor

@alicejw1 alicejw1 commented Apr 14, 2022

…tps://github.com//issues/488

Signed-off-by: alicejw alicejw@amazon.com

Description

Clarify that changes made to global tenants are not inherited by a user's private tenant. They need to make changes independently to global and private tenants.

Issues Resolved

[488 - Modify global tenant docs]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…te tenant

Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 requested a review from a team as a code owner April 14, 2022 00:47
@alicejw1 alicejw1 self-assigned this Apr 14, 2022
@Naarcha-AWS Naarcha-AWS changed the title clarify global and primary tenant functionality - issue 488 Clarify global and primary tenant functionality - issue 488 Apr 14, 2022
Signed-off-by: alicejw <alicejw@amazon.com>
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions.

_security-plugin/access-control/multi-tenancy.md Outdated Show resolved Hide resolved
_security-plugin/access-control/multi-tenancy.md Outdated Show resolved Hide resolved
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 merged commit cb02f71 into opensearch-project:main Apr 14, 2022
@alicejw1 alicejw1 deleted the global-tenant branch April 14, 2022 19:50
@alicejw1 alicejw1 linked an issue Apr 15, 2022 that may be closed by this pull request
Copy link
Contributor Author

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL][Security plugin] Modify global tenant docs
3 participants