Add a note about zstd incompatibility with k-NN and security analytics #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s plugins Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
kolchfa-aws
requested review from
cwillum,
hdhalter,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
|
@sarthakaggarwal97 Could you review this PR please? |
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
kolchfa-aws
added
the
release-notes
sarthakaggarwal97
approved these changes
Sep 14, 2023
|
LGTM! thanks @kolchfa-aws for taking this up! |
_im-plugin/index-codecs.md
Outdated
| @@ -24,6 +24,9 @@ It may be challenging to change the codec setting of an existing index (see [Cha | |||
| * `zstd` (OpenSearch 2.9 and later) -- This codec provides significant compression comparable to the `best_compression` codec with reasonable CPU usage and improved indexing and search performance compared to the `default` codec. | |||
| * `zstd_no_dict` (OpenSearch 2.9 and later) -- This codec is similar to `zstd` but excludes the dictionary compression feature. It provides faster indexing and search operations compared to `zstd` at the expense of a slightly larger index size. | |||
|
|
|||
| As of OpenSearch 2.10, the `zstd` and `zstd_no_dict` codecs are not compatible with the [k-NN]({{site.url}}{{site.baseurl}}/search-plugins/knn/index/) and [Security Analytics]({{site.url}}{{site.baseurl}}/security-analytics/index/) plugins. | |||
There was a problem hiding this comment.
Can we rephrase it to
As of OpenSearch 2.10, the
zstdandzstd_no_dictcompression codecs can not be used for k-NN and Security Analytics indices.
sarthakaggarwal97
suggested changes
Sep 14, 2023
kolchfa-aws
commented
Sep 14, 2023
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
sarthakaggarwal97
approved these changes
Sep 14, 2023
natebower
reviewed
Sep 14, 2023
natebower
approved these changes
Sep 14, 2023
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws
added
6 - Done but waiting to merge
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
opensearch-project#5014) * Add a note about zstd incompatibility with k-NN and security analytics plugins Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Capitalization Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update _im-plugin/index-codecs.md Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Update _im-plugin/index-codecs.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
#5014) * Add a note about zstd incompatibility with k-NN and security analytics plugins Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Capitalization Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update _im-plugin/index-codecs.md Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Update _im-plugin/index-codecs.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5002
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.