-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ZSTD and ZSTD_NO_DICT codecs to core (out of sandbox) #4421
Merged
hdhalter
merged 24 commits into
opensearch-project:main
from
sarthakaggarwal97:update-zstd-documentation
Jul 19, 2023
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
90e4dcf
documentation for zstd and zstd out of sandbox
sarthakaggarwal97 969d3fb
Update _api-reference/index-apis/create-index.md
hdhalter f8bc687
Update _api-reference/index-apis/create-index.md
hdhalter 57c46b0
Update _api-reference/index-apis/create-index.md
hdhalter 6c8c087
Update _api-reference/index-apis/create-index.md
hdhalter 642f364
Update _api-reference/index-apis/create-index.md
hdhalter 2cbdbdb
Update _api-reference/index-apis/create-index.md
hdhalter 0374170
Update _api-reference/index-apis/create-index.md
hdhalter d79675c
Update _api-reference/index-apis/create-index.md
hdhalter 4908884
Update create-index.md
hdhalter 793db12
Update _api-reference/index-apis/create-index.md
hdhalter a050110
Update create-index.md
hdhalter 8ae0f2d
Update _api-reference/index-apis/create-index.md
hdhalter 3a0e510
Update create-index.md
hdhalter a66b865
Update create-index.md
hdhalter 7046371
Update create-index.md
hdhalter bfc1d32
Update _api-reference/index-apis/create-index.md
hdhalter ea7964f
Update _api-reference/index-apis/create-index.md
hdhalter 9e4509a
Update _api-reference/index-apis/create-index.md
hdhalter e4e7846
Update _api-reference/index-apis/create-index.md
hdhalter 988f4df
Update _api-reference/index-apis/create-index.md
hdhalter c2feee0
Update _api-reference/index-apis/create-index.md
hdhalter 6b4fad4
Update _api-reference/index-apis/create-index.md
hdhalter 3ade466
Update _api-reference/index-apis/create-index.md
hdhalter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we will add an additional page to explain the index.codec settings around the time of release.
This information might be redundant post the addition of that page, how do you suggest we should proceed @hdhalter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling it out here: We might need to update the documentation related to snapshot, and we can check if we can add something over here at best practices for performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add more information about indexing, in general, and will add more information to support these options after the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide me an endpoint so I can test the code samples on Monday? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarthakaggarwal97 - The documentation related to snapshots has been updated. The link above to 'best practices' is part of the Service documentation and needs to be handled by @chatnish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want a domain where you can test these code samples?