-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update PUT Repository API documentation with Snapshot Interoperability w/ Remote Store related changes #4598
Comments
@harishbhakuni21 What is the default value of this optional parameter? Also, how does this interact with the same parameter in the create snapshot API described in #4599? |
@andrross So, during snapshot creation, we will check if this flag is present in repository settings or not, if it is present as true, we will take shallow copy snapshot else we will take full copy snapshot. |
@harishbhakuni21 Unless I'm misunderstanding, |
@andrross i will make the wordings a bit more clear in these issues. but we will have this flag in Repository settings and in create snapshot API response, not in create snapshot API request. during snapshot creation, we will read repository setting property and use that. Will raise another issue for a detailed doc on usage of shallow copy snapshots. |
Sorry, I had misread #4599 and now I see that the "shallow copy" field is just in the response. That makes sense, thanks @harishbhakuni21! |
Hey, no worries @andrross, thanks for looking into this request. |
tagging @hdhalter to help with the doc updates for Snapshot Interoperability w/ remote store. |
@harishbhakuni - Hi Harish, are the two updates (#4599, #4600) targeting the 2.10 release, and this one is already implemented in 2.9? |
@hdhalter yes we need all these in 2.10 release. |
What do you want to do?
Tell us about your request. Provide a summary of the request and all versions that are affected.
PUT Repository API Parameters: https://opensearch.org/docs/latest/api-reference/snapshots/create-repository/#request-parameters, https://opensearch.org/docs/latest/api-reference/snapshots/create-repository/#s3-repository
We need to add a new parameter for both
S3
andfs
Repository:What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
PR for changes in opensearch code: opensearch-project/OpenSearch#7118
Design Doc: opensearch-project/OpenSearch#6575
changes for this feature are already in 2.9 behind remote store experimental flag. to test, bring up the opensearch node with 2.9 version, enable remote store feature and then pass this in the Put Repository call, like this:
The text was updated successfully, but these errors were encountered: