Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update PUT Repository API documentation with Snapshot Interoperability w/ Remote Store related changes #4598

Closed
1 of 4 tasks
harishbhakuni opened this issue Jul 21, 2023 · 10 comments · Fixed by #4977
Closed
1 of 4 tasks
Assignees
Labels
3 - Done Issue is done/complete Sev2 High-medium priority. Upcoming release or incorrect information. snapshots v2.10.0
Milestone

Comments

@harishbhakuni
Copy link

harishbhakuni commented Jul 21, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
PUT Repository API Parameters: https://opensearch.org/docs/latest/api-reference/snapshots/create-repository/#request-parameters, https://opensearch.org/docs/latest/api-reference/snapshots/create-repository/#s3-repository

We need to add a new parameter for both S3 and fs Repository:

Request field Description
remote_store_index_shallow_copy Whether to take the snapshots of remote store enabled indices as shallow copy snapshots or not. Optional.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
PR for changes in opensearch code: opensearch-project/OpenSearch#7118
Design Doc: opensearch-project/OpenSearch#6575

changes for this feature are already in 2.9 behind remote store experimental flag. to test, bring up the opensearch node with 2.9 version, enable remote store feature and then pass this in the Put Repository call, like this:

curl -X PUT "localhost:9200/_snapshot/shallowCopyRepository" -H 'Content-Type: application/json' -d'
{
  "type": "fs",
  "settings": {
    "location": "/mnt/snapshots",
    "base_path": "shallowCopy",
    "remote_store_index_shallow_copy": true
  }
}
'
@andrross
Copy link
Member

@harishbhakuni21 What is the default value of this optional parameter? Also, how does this interact with the same parameter in the create snapshot API described in #4599?

@harishbhakuni
Copy link
Author

@andrross So, during snapshot creation, we will check if this flag is present in repository settings or not, if it is present as true, we will take shallow copy snapshot else we will take full copy snapshot.
Also, default value of this parameter will be false.

@andrross
Copy link
Member

andrross commented Jul 24, 2023

@harishbhakuni21 Unless I'm misunderstanding, remote_store_index_shallow_copy can be defined as both a property of the repository (this issue) and as a parameter to the create snapshot API (issue #4599). We need to document the behavior of how these settings interact with one another. i.e. can the create snapshot parameter override the repository property? or is it the other way around?

@harishbhakuni
Copy link
Author

@andrross i will make the wordings a bit more clear in these issues. but we will have this flag in Repository settings and in create snapshot API response, not in create snapshot API request. during snapshot creation, we will read repository setting property and use that. Will raise another issue for a detailed doc on usage of shallow copy snapshots.

@andrross
Copy link
Member

Sorry, I had misread #4599 and now I see that the "shallow copy" field is just in the response. That makes sense, thanks @harishbhakuni21!

@harishbhakuni
Copy link
Author

Hey, no worries @andrross, thanks for looking into this request.

@harishbhakuni
Copy link
Author

tagging @hdhalter to help with the doc updates for Snapshot Interoperability w/ remote store.

Issues: #4598, #4599, #4600

@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started snapshots Sev2 High-medium priority. Upcoming release or incorrect information. and removed untriaged labels Aug 1, 2023
@Naarcha-AWS Naarcha-AWS self-assigned this Aug 1, 2023
@hdhalter
Copy link
Contributor

hdhalter commented Aug 9, 2023

@harishbhakuni - Hi Harish, are the two updates (#4599, #4600) targeting the 2.10 release, and this one is already implemented in 2.9?

@harishbhakuni
Copy link
Author

@hdhalter yes we need all these in 2.10 release.

@hdhalter hdhalter added this to the v2.10 milestone Aug 14, 2023
@Naarcha-AWS
Copy link
Collaborator

We'll address issues Issues: #4598, #4599, #4600 as a single PR. Will tag the PR in this issue when a draft is up.

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started labels Sep 13, 2023
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete Sev2 High-medium priority. Upcoming release or incorrect information. snapshots v2.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants