Catch KCL known exceptions to reduce noisy log statements #5102
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb2k16
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
sb2k16
force-pushed
the
kds-handle-exceptions
branch
from
db991b9
to
6c18361
Compare
dlvenable
requested changes
Oct 24, 2024
| @@ -139,6 +142,8 @@ public Scheduler getScheduler(final Buffer<Record<Event>> buffer) { | |||
| while (scheduler == null && numRetries++ < kinesisSourceConfig.getMaxInitializationAttempts()) { | |||
| try { | |||
| scheduler = createScheduler(buffer); | |||
| } catch (SdkClientException | KinesisClientLibDependencyException | ThrottlingException ex) { | |||
| LOG.error(NOISY, "Caught exception when initializing KCL Scheduler due to {}. Will retry", ex.getMessage()); | |||
There was a problem hiding this comment.
This does not always retry as you have a numRetries above. Maybe drop the "Will retry" text or say "The number of retries remaining is N". You could count down instead of counting up in the loop above.
There was a problem hiding this comment.
Thanks @dlvenable . I will drop the Will retry part of the statement.
Signed-off-by: Souvik Bose <souvbose@amazon.com>
sb2k16
force-pushed
the
kds-handle-exceptions
branch
from
6c18361
to
26b67d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to catch KCL known exceptions to reduce noisy log statements.
Issues Resolved
Resolves #1082
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.