Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing closing parenthesis in CLOUDFRONT_ACCESS_LOG pattern #4607

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

joelmarty
Copy link
Contributor

Description

Fixes a missing parenthesis in the CLOUDFRONT_ACCESS_LOG grok pattern

Issues Resolved

Resolves #4604

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joël Marty <134835+joelmarty@users.noreply.github.com>
Copy link
Collaborator

@engechas engechas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Changes LGTM

@engechas
Copy link
Collaborator

@graytaylor0 looks like you were the original author of these patterns. Could you double check this looks fine and approve/merge if so?

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @joelmarty !

@dlvenable dlvenable merged commit 3ef20b0 into opensearch-project:main Jun 12, 2024
39 of 47 checks passed
@joelmarty joelmarty deleted the patch-1 branch June 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Grok plugin CLOUDFRONT_ACCESS_LOG pattern does not compile
3 participants