Use positive numbers in S3DlqWriterTest for consistent test success. #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter and
oeyh
as code owners
chenqi0805
approved these changes
Apr 19, 2024
graytaylor0
approved these changes
Apr 22, 2024
4 tasks
srikanthjg
pushed a commit
to srikanthjg/data-prepper
that referenced
this pull request
Apr 24, 2024
…pensearch-project#4443) Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the recent change in #4403, the DLQ write does not write for empty objects. The unit tests use a random value which would sometimes generate 0 entries. This is causing test failures and flakiness.
This change always uses a value of at least 2. I chose 2 so that all tests run with multiple values.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.