Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sass division warning #426

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

AMoo-Miki
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki AMoo-Miki changed the title Fix description on overview page Fix sass division warning Aug 23, 2024
@sejli
Copy link
Member

sejli commented Aug 23, 2024

Might need a yarn test -u. For some reason, the test and build fails with snapshots missing an iconGap property for EuiButtonContent.

@AMoo-Miki
Copy link
Contributor Author

Might need a yarn test -u. For some reason, the test and build fails with snapshots missing an iconGap property for EuiButtonContent.

Those failures are due to OUI in OSD being upgraded. The snapshots were updated in #428

Signed-off-by: Miki <miki@amazon.com>
@sejli
Copy link
Member

sejli commented Sep 5, 2024

Thanks @AMoo-Miki! Does this need to be backported to 2.x and 2.17?

@sejli sejli merged commit 53740e2 into opensearch-project:main Sep 5, 2024
12 of 13 checks passed
github-actions bot added a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 53740e2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 53740e2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit 53740e2)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit 53740e2)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants