Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add workflow to verify binary installation #375

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[Backport 2.x] Add workflow to verify binary installation #375

merged 1 commit into from
Mar 18, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Mar 1, 2024

Backport 3bfbfda from #373.

@github-actions
Add workflow to verify binary installation (#373)
e9caefb 
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 3bfbfda)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sejli
Copy link
Member

sejli commented Mar 1, 2024

@derek-ho does this need to be backported? OPENSEARCH_VERSION is set to 3.0.0, should it be different for the 2.x branch?

@derek-ho
Copy link
Contributor

derek-ho commented Mar 4, 2024

@sejli the workflow itself has a step to switch versions if necessary: https://github.com/derek-ho/setup-opensearch-dashboards/blob/main/action.yml#L81, so I think this can be merged as is. The workflow doesn't seem to be run though - is that expected? There is some issue where we don't have 2.13 min artifact for OSD yet so even if its run it will probably fail 😅

@sejli
Copy link
Member

sejli commented Mar 4, 2024

@sejli the workflow itself has a step to switch versions if necessary: https://github.com/derek-ho/setup-opensearch-dashboards/blob/main/action.yml#L81, so I think this can be merged as is. The workflow doesn't seem to be run though - is that expected? There is some issue where we don't have 2.13 min artifact for OSD yet so even if its run it will probably fail 😅

Just now realizing that our backport workflows may be broken due to our backport bot setup. Will look into it to get that fixed...

@sejli sejli merged commit 6779bc2 into 2.x Mar 18, 2024
2 checks passed
@github-actions github-actions bot deleted the backport-373-to-2.x branch March 18, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@macohen macohen Awaiting requested review from macohen macohen is a code owner

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Search Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sejli @derek-ho