Fix reporting discover #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
commented
Sep 19, 2023
| @@ -87,7 +91,7 @@ const generateInContextReport = async ( | |||
| }; | |||
|
|
|||
| fetch( | |||
| `${getApiPath()}/reporting/generateReport?${new URLSearchParams( | |||
| `../api/reporting/generateReport?${new URLSearchParams( | |||
There was a problem hiding this comment.
There is something wrong here - getApiPath is returning two different things for discover 1.0 and discover 2.0, causing reporting to fail when in new discover, need to look into this
Signed-off-by: Derek Ho <dxho@amazon.com>
|
it doesn't work for me with basepath set |
Signed-off-by: Derek Ho <dxho@amazon.com>
joshuali925
reviewed
Sep 19, 2023
| @@ -87,7 +91,7 @@ const generateInContextReport = async ( | |||
| }; | |||
|
|
|||
| fetch( | |||
| `${getApiPath()}/reporting/generateReport?${new URLSearchParams( | |||
| `../${getApiPath()}/reporting/generateReport?${new URLSearchParams( | |||
There was a problem hiding this comment.
instead of this, try adding if (window.location.href.includes('/data-explorer/discover/')) return '../../../api' in line 339 (above the other if)
Signed-off-by: Derek Ho <dxho@amazon.com>
joshuali925
approved these changes
Sep 19, 2023
6 tasks
ps48
approved these changes
Sep 19, 2023
YANG-DB
approved these changes
Sep 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Fix reporting discover Signed-off-by: Derek Ho <dxho@amazon.com> * Get it to work Signed-off-by: Derek Ho <dxho@amazon.com> * Revert api file and add extra quote for regex matching Signed-off-by: Derek Ho <dxho@amazon.com> * Add extra condition if coming from dashboards management Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 2d643cc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Fix reporting discover Signed-off-by: Derek Ho <dxho@amazon.com> * Get it to work Signed-off-by: Derek Ho <dxho@amazon.com> * Revert api file and add extra quote for regex matching Signed-off-by: Derek Ho <dxho@amazon.com> * Add extra condition if coming from dashboards management Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 2d643cc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Sep 19, 2023
joshuali925
pushed a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.