Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Fix panel resizing and date picker bugs #364

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Apr 17, 2023

Description

Fixed issues:

  • visualization container resizing does not get reflected after page refresh
  • change date range using date picker doesn't get applied correctly to all visualizations in panels

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
…zation

Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric merged commit fcb1474 into opensearch-project:main Apr 17, 2023
@mengweieric mengweieric deleted the issue/panel-resize branch April 17, 2023 16:42
pjfitzgibbons pushed a commit that referenced this pull request Apr 17, 2023
* fix panel resizing issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix bug of panel relayout not reflected after page refresh

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel date picker issue for new panel/visualization

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix bug of not seeing  panel daterange change reflected for old visulization

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
pjfitzgibbons pushed a commit that referenced this pull request Apr 18, 2023
* fix panel resizing issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix bug of panel relayout not reflected after page refresh

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel date picker issue for new panel/visualization

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix bug of not seeing  panel daterange change reflected for old visulization

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit fcb1474)
joshuali925 pushed a commit to joshuali925/dashboards-observability that referenced this pull request Apr 18, 2023
* fix panel resizing issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix bug of panel relayout not reflected after page refresh

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel date picker issue for new panel/visualization

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix bug of not seeing  panel daterange change reflected for old visulization

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants