Gantt Chart / Service Map followup #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
paulstn
reviewed
Dec 19, 2024
.cypress/integration/trace_analytics_test/trace_analytics_services.spec.js
Show resolved
Hide resolved
paulstn
reviewed
Dec 19, 2024
.cypress/integration/trace_analytics_test/trace_analytics_traces.spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Tackett <tackadam@amazon.com>
mengweieric
approved these changes
Dec 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix resizing bug, style fixes Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix cypress flaky test Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix flaky analytics test Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix flaky pagnation test Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix for flaky node check Signed-off-by: Adam Tackett <tackadam@amazon.com> * remove .only Signed-off-by: Adam Tackett <tackadam@amazon.com> * remove only Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> (cherry picked from commit 36cdef5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix resizing bug, style fixes * fix cypress flaky test * fix flaky analytics test * fix flaky pagnation test * fix for flaky node check * remove .only * remove only --------- (cherry picked from commit 36cdef5) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fast follow action items on code styling from:
#2257
#2264
Moving functions declaration out of use effect
Styling change for onRelayout
Cypress test flakiness fixes
Bug fix: resizing handling for Span list / Tree view
Before:
Before.mov
After: (Now reacts correctly to full screen and side navigation changes)
After.mov
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.