Fix mds ref update on integration assets #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
joshuali925
reviewed
Nov 1, 2024
| @@ -207,7 +207,7 @@ export class IntegrationInstanceBuilder { | |||
| dataSourceMDSId?: string, | |||
| dataSourceMDSLabel?: string | |||
| ): SavedObject[] { | |||
| if (!dataSource) { | |||
| if (!dataSourceMDSId) { | |||
There was a problem hiding this comment.
what's the difference? and is dataSource still used?
There was a problem hiding this comment.
Datasource is the flint one. We need to fix the naming soon in whole code-base.
joshuali925
approved these changes
Nov 1, 2024
TackAdam
approved these changes
Nov 1, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2240 +/- ##
==========================================
- Coverage 56.58% 56.26% -0.32%
==========================================
Files 389 391 +2
Lines 14954 15158 +204
Branches 4059 4073 +14
==========================================
+ Hits 8462 8529 +67
- Misses 6430 6567 +137
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RyanL1997
approved these changes
Nov 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
* fix mds ref update on integration assests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add unit test for builder with mds enabled Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 10e6636) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Nov 5, 2024
* fix mds ref update on integration assests * add unit test for builder with mds enabled --------- (cherry picked from commit 10e6636) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix mds reference update on integration assets
Issues Resolved
Mds reference was not getting added for integrations there were two issues:
integration-mds-ref.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.