Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update getting started cards content and visual design #2209

Merged

Conversation

virajsanghvi
Copy link
Contributor

@virajsanghvi virajsanghvi commented Oct 17, 2024

Description

This updates getting started cards for observability overview page to new content and visual design.

Please do review, but don't merge yet as it requires an oui bump in osd (should land tomorrow afternoon) and opensearch-project/OpenSearch-Dashboards#8614 to be completed. Also, please make sure this gets backported to 2.x.

New cards:
image

This functionality is not currently tested so I did not add tests. Please let me know if there's a changelog mechanism I should know about.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi virajsanghvi marked this pull request as draft October 17, 2024 06:28
@virajsanghvi
Copy link
Contributor Author

There are a lot of errors/failing checks, but I don't think they're related and these fail in other PRs. If I'm doing something to trigger any of these, please let me know.

@virajsanghvi virajsanghvi marked this pull request as ready for review October 17, 2024 16:32
@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Oct 17, 2024
Copy link
Collaborator

@TackAdam TackAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you

@TackAdam TackAdam mentioned this pull request Oct 17, 2024
6 tasks
Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, failing tests are unrelated.

@TackAdam TackAdam merged commit 4b5b364 into opensearch-project:main Oct 18, 2024
14 of 23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 4b5b364)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit to mengweieric/dashboards-observability that referenced this pull request Oct 18, 2024
TackAdam pushed a commit that referenced this pull request Oct 18, 2024
…2212)

(cherry picked from commit 4b5b364)

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997 pushed a commit that referenced this pull request Oct 18, 2024
…pping issue (#2211)

* updated release notes (#1997)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* xaxis label default to rotate 45 angle

Signed-off-by: Eric <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric <menwe@amazon.com>

* fix: Update getting started cards content and visual design (#2209)

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* updated release notes (#1997)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* updated release notes (#1997)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* update other snapshots

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: Sumukh Swamy <sumukhhs@amazon.com>
Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
…pping issue (#2211)

* updated release notes (#1997)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* xaxis label default to rotate 45 angle

Signed-off-by: Eric <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric <menwe@amazon.com>

* fix: Update getting started cards content and visual design (#2209)

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* updated release notes (#1997)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* updated release notes (#1997)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* update other snapshots

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: Sumukh Swamy <sumukhhs@amazon.com>
Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit d5853bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam pushed a commit that referenced this pull request Oct 18, 2024
…pping issue (#2211) (#2215)

* updated release notes (#1997)



* xaxis label default to rotate 45 angle



* update snapshots



* fix: Update getting started cards content and visual design (#2209)



* updated release notes (#1997)



* updated release notes (#1997)



* update other snapshots



---------






(cherry picked from commit d5853bc)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sumukh Swamy <sumukhhs@amazon.com>
Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants