Fix data connection api 404 error #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <menwe@amazon.com>
mengweieric
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
sumukhswamy
approved these changes
May 1, 2024
ps48
approved these changes
May 1, 2024
Swiddis
approved these changes
May 1, 2024
|
May be worth adding a unit/integration test to avoid repeat occurrence |
RyanL1997
approved these changes
May 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 441168e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 441168e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
May 2, 2024
mengweieric
pushed a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/dataconnections API is failing with 404 due to changes introduced from this change: this PR fix this issue.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.