[Backport 2.x] Update integrations to allow custom checkpoint locations #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Update integration type for new format Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update integration type validator for new type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix type errors in integration_reader Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix return types in adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update integrations constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix local repository and local repository tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix remaining integrations unit tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add integration format migration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix frontend usage of integration assets Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update integration install query iteration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add checkpoint field to setup form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update checkpoint text based on UI feedback Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add new checkpoint usage to setup flow Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Split out integrations setup methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit dec4ff2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
ps48
approved these changes
Mar 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1511 +/- ##
==========================================
+ Coverage 54.73% 54.79% +0.05%
==========================================
Files 345 345
Lines 12347 12354 +7
Branches 3171 3168 -3
==========================================
+ Hits 6758 6769 +11
+ Misses 5533 5530 -3
+ Partials 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Mar 11, 2024
Swiddis
added
enhancement
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…project#1501) (opensearch-project#1511) * Update integration type for new format * Update integration type validator for new type * Fix type errors in integration_reader * Fix return types in adaptor * Update integrations constants * Fix local repository and local repository tests * Fix remaining integrations unit tests * Add integration format migration * Fix frontend usage of integration assets * Update integration install query iteration * Add checkpoint field to setup form * Update checkpoint text based on UI feedback * Add new checkpoint usage to setup flow * Split out integrations setup methods --------- (cherry picked from commit dec4ff2) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 3191614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport dec4ff2 from #1501.